feat: ignore .md files when do requiresJenkinsRun check

nodejs · Jul 12, 2022 · f034f8c · f034f8c
1 parent 460b50d
commit f034f8c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/pr_checker.js b/lib/pr_checker.js
@@ -404,6 +404,14 @@ export default class PRChecker {
       return false;
     }
 
+    const files = pr.files.nodes;
+
+    // Don't require Jenkins run if pr is doc-only changes
+    const isDocOnlyChange = files.every(({ path }) => path.endsWith('.md'));
+    if (isDocOnlyChange) {
+      return false;
+    }
+
     const ciNeededFolderRx = /^(deps|lib|src|test)\//;
     const ciNeededToolFolderRx =
       /^tools\/(code_cache|gyp|icu|inspector|msvs|snapshot|v8_gypfiles)/;
@@ -416,7 +424,7 @@ export default class PRChecker {
     ];
     const ciNeededExtensionList = ['.gyp', '.gypi', '.bat'];
 
-    return pr.files.nodes.some(
+    return files.some(
       ({ path }) =>
         ciNeededFolderRx.test(path) ||
         ciNeededToolFolderRx.test(path) ||

diff --git a/test/fixtures/pull_requests/doc-only.json b/test/fixtures/pull_requests/doc-only.json
@@ -35,6 +35,12 @@
       },
       {
         "path": "doc/api/package_json.md"
+      },
+      {
+        "path": "tools/icu/README.md"
+      },
+      {
+        "path": "deps/ngtcp2/README.md"
       }
     ]
   },