Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor V8 updates are broken #850

Closed
targos opened this issue Sep 1, 2024 · 0 comments · Fixed by #851
Closed

minor V8 updates are broken #850

targos opened this issue Sep 1, 2024 · 0 comments · Fixed by #851

Comments

@targos
Copy link
Member

targos commented Sep 1, 2024

$ git node v8 --v8-dir ~/git/chromium/v8/v8 minor
✔ Update local V8 clone
❯ Minor V8 update
  ✔ Get current V8 version
  ✔ Get latest V8 version
  ✖ The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an
    instance of ChildProcess
◼ Commit V8 update
✖ The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess
targos added a commit to targos/node-core-utils that referenced this issue Sep 1, 2024
Capture stdout so it can be used in the catch block when there is a conflict.

Fixes: nodejs#850
targos added a commit that referenced this issue Sep 3, 2024
Capture stdout so it can be used in the catch block when there is a conflict.

Fixes: #850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant