Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: support readme configuration #223

Merged
merged 1 commit into from
Mar 31, 2018

Conversation

joyeecheung
Copy link
Member

Also fixes the status code handling in git-node.

Fixes: #212

screen shot 2018-03-31 at 10 04 28 pm

Also fixes the status code handling in git-node.
@codecov
Copy link

codecov bot commented Mar 31, 2018

Codecov Report

Merging #223 into master will decrease coverage by 4.09%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #223     +/-   ##
=========================================
- Coverage    92.1%   88.01%   -4.1%     
=========================================
  Files          18       19      +1     
  Lines         659      701     +42     
=========================================
+ Hits          607      617     +10     
- Misses         52       84     +32
Impacted Files Coverage Δ
lib/run.js 21.62% <100%> (ø)
lib/cli.js 51.42% <33.33%> (+0.7%) ⬆️
lib/pr_data.js 91.52% <40%> (-4.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598a3a2...b71a1b2. Read the comment docs.

Copy link
Contributor

@priyank-p priyank-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, work.

@joyeecheung joyeecheung merged commit 3fe2049 into nodejs:master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get-metadata outputs errors it shouldn't due to "exit no-zero on failure" feature
2 participants