Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge update-v8 in the project #235

Merged
merged 2 commits into from
Apr 19, 2018
Merged

Conversation

targos
Copy link
Member

@targos targos commented Apr 13, 2018

Moving my code from https://github.com/targos/update-v8

I tried to do it with minimal code changes:

  • Switched CLI arguments parser to yargs
  • Changed the backport command from update-v8 backport --sha=xxx to update-v8 backport xxx because this option has always been mandatory
  • Restructured the documentation a bit
  • Did not bring all the gypfiles because they were only necessary to do the update to V8 6.6 (and that update landed on Node master)

Fixes: #234

@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files          19       19           
  Lines         707      707           
=======================================
  Hits          626      626           
  Misses         81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e3fb1...d12fd20. Read the comment docs.

@devsnek
Copy link
Member

devsnek commented Apr 13, 2018

ideally this could move invocation under git-node or ncu instead of having its own name?

@targos
Copy link
Member Author

targos commented Apr 13, 2018

Sure. git node update-v8 ?

@devsnek
Copy link
Member

devsnek commented Apr 13, 2018

@targos sgtm ¯\_(ツ)_/¯

@joyeecheung
Copy link
Member

May be just git node v8? We could introduce something like git node npm later, if anyone thinks it's appropriate.

@joyeecheung
Copy link
Member

Or maybe git node deps v8 although it seems a bit wordy

@targos
Copy link
Member Author

targos commented Apr 14, 2018

changed to git node v8

@targos
Copy link
Member Author

targos commented Apr 19, 2018

@nodejs/automation

@joyeecheung joyeecheung merged commit 969987b into nodejs:master Apr 19, 2018
@targos targos deleted the update-v8 branch April 19, 2018 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants