Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak CI walk filter order #329

Closed
wants to merge 1 commit into from
Closed

Tweak CI walk filter order #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions lib/ci/ci_failure_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,25 +203,23 @@ const FAILURE_FILTERS = [{
}, {
filter(ctx, text) {
const patterns = [{
pattern: /There is not enough space in the file system./g,
context: { index: 0, contextBefore: 0, contextAfter: 5 }
pattern: /FATAL: .+/g,
context: { index: -1, contextBefore: 0, contextAfter: 5 }
}, {
pattern: /sh: line /g,
context: { index: 0, contextBefore: 0, contextAfter: 1 }
pattern: /make.*: write error/mg,
context: { index: 0, contextBefore: 0, contextAfter: 3 }
}, {
pattern: /fatal error:/g,
context: { index: 0, contextBefore: 0, contextAfter: 1 }
pattern: /error: .+/g,
context: { index: 0, contextBefore: 0, contextAfter: 5 }
}, {
pattern: /dtrace: failed to compile script/g,
context: { index: 0, contextBefore: 0, contextAfter: 1 }
pattern: /Makefile:.+failed/g,
context: { index: 0, contextBefore: 0, contextAfter: 5 }
}, {
pattern: /ERROR: .+/g,
// Pick the last one
context: { index: -1, contextBefore: 0, contextAfter: 5 }
pattern: /make.*: .+ Error \d.*/g,
context: { index: 0, contextBefore: 0, contextAfter: 3 }
}, {
// Pick the first one
pattern: /Error: .+/g,
context: { index: 0, contextBefore: 0, contextAfter: 5 }
pattern: /warning: failed .+/g,
context: { index: 0, contextBefore: 0, contextAfter: 3 }
}];
return failureMatcher(BuildFailure, patterns, ctx, text);
}
Expand All @@ -238,23 +236,25 @@ const FAILURE_FILTERS = [{
}, {
filter(ctx, text) {
const patterns = [{
pattern: /FATAL: .+/g,
context: { index: -1, contextBefore: 0, contextAfter: 5 }
pattern: /There is not enough space in the file system./g,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ones moved here are actually more specific? Can you split those instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I wrote this patch on GitHub, hoping I hit it in one try ¯\(ツ)/¯
I need to dig into this locally a bit more...

context: { index: 0, contextBefore: 0, contextAfter: 5 }
}, {
pattern: /make.*: write error/mg,
context: { index: 0, contextBefore: 0, contextAfter: 3 }
pattern: /sh: line /g,
context: { index: 0, contextBefore: 0, contextAfter: 1 }
}, {
pattern: /error: .+/g,
context: { index: 0, contextBefore: 0, contextAfter: 5 }
pattern: /fatal error:/g,
context: { index: 0, contextBefore: 0, contextAfter: 1 }
}, {
pattern: /Makefile:.+failed/g,
context: { index: 0, contextBefore: 0, contextAfter: 5 }
pattern: /dtrace: failed to compile script/g,
context: { index: 0, contextBefore: 0, contextAfter: 1 }
}, {
pattern: /make.*: .+ Error \d.*/g,
context: { index: 0, contextBefore: 0, contextAfter: 3 }
pattern: /ERROR: .+/g,
// Pick the last one
context: { index: -1, contextBefore: 0, contextAfter: 5 }
}, {
pattern: /warning: failed .+/g,
context: { index: 0, contextBefore: 0, contextAfter: 3 }
// Pick the first one
pattern: /Error: .+/g,
context: { index: 0, contextBefore: 0, contextAfter: 5 }
}];
return failureMatcher(BuildFailure, patterns, ctx, text);
}
Expand Down