ci-parser: fix detection of lite CI pipelines

[richardlau]

Fixes: #353

cc @sam-github

[codecov]

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   75.95%   75.95%           
=======================================
  Files          21       21           
  Lines        1364     1364           
=======================================
  Hits         1036     1036           
  Misses        328      328

Impacted Files	Coverage Δ
lib/ci/ci_type_parser.js	80.95% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d64553...433293a. Read the comment docs.

[sam-github]

RSLGTM, though will it match with or with the trailing pipeline? Should both cases be tested? I don't know, just asking, and thanks for fixing this.

[richardlau]

RSLGTM, though will it match with or with the trailing pipeline? Should both cases be tested? I don't know, just asking, and thanks for fixing this.

There's still a test that has the /pipeline suffix that I left alone (and still passes):

node-core-utils/test/unit/pr_checker.test.js

Line 574 in 433293a

'https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/7213/pipeline/'

[sam-github]

I'm not sure what the policy is here, if it is like node core, but I'm in support of fast-tracking and publishing this fix.

[joyeecheung]

@sam-github The policy is basically "this can land whenever it gets an approval from someone who can write to this repo" or at least that's what we have been doing.