fix: validate ncu-ci args #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
validate-ncu-ci-args
branch
2 times, most recently
from
425fab1 to
6408ccd
Compare
codebytere
force-pushed
the
validate-ncu-ci-args
branch
from
6408ccd to
4cba1ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
=======================================
Coverage 76.28% 76.28%
=======================================
Files 21 21
Lines 1480 1480
=======================================
Hits 1129 1129
Misses 351 351 Continue to review full report at Codecov.
|
targos
reviewed
May 12, 2020
Comment on lines
+133
to
140
| }).check(argv => { | ||
| if (argv.markdown && commandKeys.includes(argv.markdown)) { | ||
| throw new Error('--markdown <path> did not specify a valid path'); | ||
| } else if (argv.json && commandKeys.includes(argv.json)) { | ||
| throw new Error('--json <path> did not specify a valid path'); | ||
| } | ||
| return true; | ||
| }) |
There was a problem hiding this comment.
I think we can use requiresArg: true in the option's definition instead of manual validation
|
@targos i tried that initially but it didn't seem to have the desired effect - it just silently fails as before: if i specify: with no manual validation Looks like there might be a bug: yargs/yargs#1041 |
targos
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #393.
Not a perfect solution, but this validates that the user didn't type something like:
and throws a helpful error if that's the case.
cc @mmarchini @joyeecheung