Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spacing in warnForWrongBranch() #448

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

codebytere
Copy link
Member

Fixes a teeny spacing issue in warnForWrongBranch() when running release prep:

Before:

node on git:v14.x-staging ❯ g node release --prepare                           8:33PM
   ⚠  You are trying to create a new release proposal branch for v15, but you're checked out on v14.x-staging and not v15.x-staging.
--------------------------------------------------------------------------------
   ℹ  Switch to `v15.x-staging` with `gitcheckout v15.x-staging` before proceeding.
--------------------------------------------------------------------------------

After:

node on git:v14.x-staging ❯ g node release --prepare                           8:34PM
   ⚠  You are trying to create a new release proposal branch for v15, but you're checked out on v14.x-staging and not v15.x-staging.
--------------------------------------------------------------------------------
   ℹ  Switch to `v15.x-staging` with `git checkout v15.x-staging` before proceeding.
--------------------------------------------------------------------------------

cc @targos @BridgeAR

@codebytere codebytere requested review from targos and BridgeAR June 28, 2020 03:36
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #448 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files          21       21           
  Lines        1497     1497           
=======================================
  Hits         1154     1154           
  Misses        343      343           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060ae21...608ac6a. Read the comment docs.

@codebytere codebytere merged commit d8c024d into nodejs:master Jun 28, 2020
@codebytere codebytere deleted the fix-spacing branch June 28, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants