-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable parsing citgm-nobuild jobs #458
Conversation
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 76.61% 76.72% +0.10%
==========================================
Files 21 21
Lines 1591 1598 +7
==========================================
+ Hits 1219 1226 +7
Misses 372 372
Continue to review full report at Codecov.
|
The summary for nobuild jobs is a bit of a downer but i think that probably needs to be fixed on the CI config side instead of on this end. |
In what respect? FWIW the particular run of the job in the example, https://ci.nodejs.org/job/citgm-smoker-nobuild/866/, specifically only ran tests for the |
5de5d9c
to
b091609
Compare
@richardlau this:
I'm not 100% sure why it returns unknown but it's be ideal for it to show the release commit for the last released tarball if possible! |
Ah right, yeah the job doesn't know what commit was used. What the job does is scrape the appropriate directory in https://nodejs.org/download/ (e.g. https://nodejs.org/download/release/ when "release" is selected for For releases perhaps node-core-utils could tie them back to tags in the core repo but I don't think we could do that for the rc builds. |
b091609
to
1c22838
Compare
Refs #454.
Extends
ncu-ci citgm
by allowing for users to also checkcitgm-smoker-nobuild
jobs. To specify that a job is anobuild
job, one would run:Output:
JSON Output
Markdown Output
cc @MylesBorins