Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return value for validateLint #482

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 17, 2020

Fixes an issue where make lint doesn't return anything, so awaiting it would always return undefined on success and false-positive fail. Also adds logging output for successful lint.

cc @nodejs/node-core-utils

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #482 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files          34       34           
  Lines        1660     1660           
=======================================
  Hits         1371     1371           
  Misses        289      289           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6d1e2...0a46d4c. Read the comment docs.

@codebytere codebytere merged commit e379e9f into nodejs:master Aug 19, 2020
@codebytere codebytere deleted the fix-lint branch August 19, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants