-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: auto-publish package to npm after release #511
Conversation
Labeled "do not land" because we need to setup the npm token if this is accepted. |
This comment has been minimized.
This comment has been minimized.
This would remove 2FA when we publish. Are we ok with that? |
npm now has automation tokens now, so we don't have to disable 2FA requirements on the package. AFAIU the only risk we would have is that someone with write access to this repo pushes something to steal the token? |
We still drop 2FA for our "main" publish workflow (assuming the automation becomes the main workflow). It's not ideal IMO but probably low risk enough that we can try it? |
GitHub Actions now have environment protection rules and environment secrets: https://github.blog/changelog/2020-12-15-github-actions-environments-environment-protection-rules-and-environment-secrets-beta/ |
I will reimplement the change differently if it's likely to land. |
Updated. We still need to setup an npm automation token before merging this. Who would be able to do that? |
The NPM_TOKEN secret is installed. Would you like to review again? |
No description provided.