-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prepare for one last README change #578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using remark to format markdown files is going to require one final README.md format change. This accommodates that change while being backward-compatible with previous formats.
Codecov Report
@@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 82.57% 82.57%
=======================================
Files 35 35
Lines 1750 1750
=======================================
Hits 1445 1445
Misses 305 305
Continue to review full report at Codecov.
|
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 29, 2021
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 29, 2021
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 29, 2021
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release.
aduh95
approved these changes
Oct 29, 2021
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 30, 2021
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 30, 2021
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 31, 2021
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release. PR-URL: nodejs#40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 6, 2021
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release. PR-URL: #40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 29, 2022
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release. PR-URL: #40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using remark to format markdown files is going to require one final
README.md format change. This accommodates that change while being
backward-compatible with previous formats.