Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to ESM #601

Merged
merged 1 commit into from
Jan 18, 2022
Merged

refactor: migrate to ESM #601

merged 1 commit into from
Jan 18, 2022

Conversation

targos
Copy link
Member

@targos targos commented Dec 23, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #601 (6d99b3d) into main (bdfbb6e) will increase coverage by 3.77%.
The diff coverage is 95.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   80.30%   84.07%   +3.77%     
==========================================
  Files          37       37              
  Lines        1828     4051    +2223     
==========================================
+ Hits         1468     3406    +1938     
- Misses        360      645     +285     
Impacted Files Coverage Δ
lib/run.js 25.00% <57.89%> (+7.00%) ⬆️
lib/links.js 92.00% <85.71%> (+3.26%) ⬆️
lib/config.js 86.76% <86.36%> (+5.81%) ⬆️
lib/auth.js 85.71% <100.00%> (+5.27%) ⬆️
lib/cache.js 100.00% <100.00%> (ø)
lib/ci/build-types/benchmark_run.js 90.27% <100.00%> (+2.47%) ⬆️
lib/ci/build-types/citgm_build.js 75.77% <100.00%> (+4.03%) ⬆️
lib/ci/build-types/citgm_comparison_build.js 67.24% <100.00%> (+8.15%) ⬆️
lib/ci/build-types/commit_build.js 79.46% <100.00%> (+0.15%) ⬆️
lib/ci/build-types/fanned_build.js 31.03% <100.00%> (+12.61%) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdfbb6e...6d99b3d. Read the comment docs.

@targos
Copy link
Member Author

targos commented Jan 11, 2022

@nodejs/node-core-utils

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@targos targos merged commit 919ec3b into main Jan 18, 2022
@targos targos deleted the esm branch January 18, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants