chore: remove execa dependency
#722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 37 37
Lines 4158 4158
=======================================
Hits 3467 3467
Misses 691 691 ☔ View full report in Codecov by Sentry. |
VoltrexKeyva
approved these changes
Sep 3, 2023
MoLow
approved these changes
Sep 4, 2023
|
This seems to have broken |
targos
reviewed
Sep 5, 2023
| return runAsync('git', args, { | ||
| spawnArgs: { | ||
| cwd: options.nodeDir, | ||
| ...input && { input } |
There was a problem hiding this comment.
spawn doesn't take an input option.
targos
reviewed
Sep 5, 2023
| captureStdout: true, | ||
| spawnArgs: { | ||
| cwd: ctx.v8Dir, | ||
| encoding: 'utf8' |
There was a problem hiding this comment.
nor does it take an encoding option
targos
reviewed
Sep 5, 2023
| 'git', | ||
| ['format-patch', '--stdout', `${ctx.currentVersion}...${latestStr}`], | ||
| { cwd: ctx.v8Dir, encoding: 'utf8' } | ||
| { captureStdout: true, spawnArgs: { cwd: ctx.v8Dir, encoding: 'utf8' } } |
targos
reviewed
Sep 5, 2023
| await runAsync('git', ['apply', '--directory', 'deps/v8'], { | ||
| spawnArgs: { | ||
| cwd: ctx.nodeDir, | ||
| input: diff |
Closed
targos
added a commit
to targos/node-core-utils
that referenced
this pull request
Sep 11, 2023
This reverts commit ff79809.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The less dependencies we have, the better.