Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add team mention when notifying #793

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: add team mention when notifying #793

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e81ee98
fix: add team mention when notifying
RafaelGSS Mar 28, 2024
c127c7a
Update lib/security-announcement.js
RafaelGSS Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/security-announcement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ export default class SecurityAnnouncement {
repo: 'build'
};

const { title, content } = this.createPreleaseAnnouncementIssue(releaseDate);
const { title, content } = this.createPreleaseAnnouncementIssue(releaseDate, 'build');
await this.createIssue(title, content, repository);
}

createPreleaseAnnouncementIssue(releaseDate) {
createPreleaseAnnouncementIssue(releaseDate, team) {
const title = `[NEXT-SECURITY-RELEASE] Heads up on upcoming Node.js\
security release ${formatDateToYYYYMMDD(releaseDate)}`;
const content = 'As per security release workflow,' +
' creating issue to give docker team a heads up.';
` creating issue to give docker ${team} a heads up.`;
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
return { title, content };
}

Expand All @@ -67,7 +67,7 @@ export default class SecurityAnnouncement {
repo: 'docker-node'
};

const { title, content } = this.createPreleaseAnnouncementIssue(releaseDate);
const { title, content } = this.createPreleaseAnnouncementIssue(releaseDate, 'docker');
await this.createIssue(title, content, repository);
}

Expand Down
Loading