Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vote): improve UX when posting comment fails #814

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 7, 2024

When the token doesn't have the permission to post the comment directly, we can fallback to showing the user the error message and what command they should type.

When the token doesn't have the permission to post the comment directly,
we can fallback to showing the user the error message and what command
they should type.
lib/voting_session.js Outdated Show resolved Hide resolved
@aduh95 aduh95 merged commit 615fbac into nodejs:main Jun 8, 2024
9 checks passed
@aduh95 aduh95 deleted the improve-fallback-comment branch June 8, 2024 13:47
This was referenced Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants