-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: improve issue template #1618
Conversation
Suggest using --verbose npm switch when providing logs. Hopefully, better direct users to use backticks correctly.
.github/ISSUE_TEMPLATE.md
Outdated
Paste your log here, between the backticks. It can be: | ||
- npm --verbose output, | ||
- or contents of npm-debug.log, | ||
- or verbose build output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- or verbose build output. | |
- output of `node-gyp rebuild --verbose` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you include João's suggestion.
I don't have write access here, can someone land this please? |
Suggest using --verbose npm switch when providing logs. Hopefully, better direct users to use backticks correctly. PR-URL: #1618 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/113/ ✔️ Landed in 53b6074 |
Suggest using --verbose npm switch when providing logs. Hopefully, better direct users to use backticks correctly. PR-URL: #1618 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Checklist
Description of change
Improve the issue template:
--verbose
npm switch when providing logs