Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Add the long dead Python 2.6 #1913

Closed
wants to merge 1 commit into from
Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 4, 2019

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

As discussed in #1912, we need to test software that we claim to support.

@cclauss cclauss changed the base branch from master to v5.x October 4, 2019 05:25
@rvagg rvagg force-pushed the Python-2.6-on-Precise branch from 8ed79ba to 56a7db2 Compare October 4, 2019 05:33
@rvagg
Copy link
Member

rvagg commented Oct 4, 2019

remade the branch and cherry-picked the HEAD commit onto it so it's properly on v5.x now, will watch Travis to see what it says, regardless I don't think this is (a) needed or (b) requires us to document it, it's just not something we can change on v5.x because it's been baked in already.

@rvagg rvagg force-pushed the Python-2.6-on-Precise branch from 56a7db2 to f5e6151 Compare October 4, 2019 05:35
@cclauss
Copy link
Contributor Author

cclauss commented Oct 4, 2019

I rebased on v5.x at same time you did so who knows what we got. Let’s see what Travis says. If it fails then I believe our release notes should reflect that.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 4, 2019

Flake8 no longer supports Python 2.6 but even when flake8 is fully disabled, the Py26 run fails.

@cclauss cclauss added the Python label Oct 4, 2019
@rvagg rvagg force-pushed the Python-2.6-on-Precise branch from b0886b7 to 5951add Compare October 4, 2019 11:43
@rvagg
Copy link
Member

rvagg commented Oct 4, 2019

it failed because it's running Node 0.10 on that image, I switched to 10 (nvm install 10), but then it failed because it didn't have semverRange, so I rebased onto rvagg/restore-python-2.6, but then it's failing because the compilers is too old on precise: https://travis-ci.com/nodejs/node-gyp/jobs/242023105, but that's a pretty good sign that it actually works, or at least it's not failing because of Python 2.6, it's making the build resources so getting cleanly through gyp. Would be interesting to figure out how to make this run. Can we do 2.6 on a newer image than precise?

@cclauss
Copy link
Contributor Author

cclauss commented Oct 4, 2019

Try upgrading to trusty

@rvagg
Copy link
Member

rvagg commented Oct 4, 2019

green with trusty 👍 will merge this into v5.x

PR-URL: #1913
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg rvagg force-pushed the Python-2.6-on-Precise branch from 2979a1c to d1cf121 Compare October 4, 2019 12:42
@rvagg
Copy link
Member

rvagg commented Oct 4, 2019

No, I won't add this, because it disables flake8 for everything, we'll need to differentiate before it can land. I've cleaned it up into a single commit on top of the current v5.x and force pushed it up.

@cclauss cclauss closed this Oct 15, 2019
@cclauss cclauss deleted the Python-2.6-on-Precise branch October 15, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants