Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps to roughly match current npm@6 #1920

Closed
wants to merge 1 commit into from
Closed

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 15, 2019

Some overdue dependency updates. I've had a look through the details of most of these updates and I'm not finding anything that would likely impact us. I'm also removing the broad dependency options (||) which used to be useful when npm was shipping very different versions. I believe they're just shipping version 6 now. Most of the changes here are matching the dependencies that the current npm master is using. I think with these changes, env-paths might be the only thing we're pulling in to npm when bundled.

There's newer versions of some of these, like tar (this update was prompted by #1918), but npm isn't shipping that yet. I suspect npm is holding back on a lot of updates to maintain older Node compatibility (the README says v6 but .travis.yml says v8).

I believe these changes can be safely backported to v5.x.

@joaocgreis
Copy link
Member

Rebased and force-pushed to clear the Windows Travis failure.

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/167/

Copy link
Member

@joaocgreis joaocgreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis still pending

rvagg added a commit that referenced this pull request Oct 24, 2019
PR-URL: #1920
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg
Copy link
Member Author

rvagg commented Oct 24, 2019

c60c22d

@rvagg rvagg closed this Oct 24, 2019
@rvagg rvagg deleted the rvagg/update-deps branch October 24, 2019 03:53
rvagg added a commit that referenced this pull request Nov 18, 2019
PR-URL: #1920
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants