-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for macOS Catalina Software Updates #2078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. It would be really cool if someone from Apple got involved and provided a more reliable way of doing this.
@cclauss Definitely, would be really nice to have a better workflow here! It would be nice if the existing command-line tools installation would just keep working after software updates. Or at least having some command to fix the installation easily. |
@gibfahn are you still with Apple? I don't suppose you could help us find someone there that can help us out here. We're still dealing with a steady stream of folks on Catalina that need to run through hoops just to get to a compile state. See dedicated doc this PR references (https://github.com/nodejs/node-gyp/blob/master/macOS_Catalina.md). |
macOS_Catalina.md
Outdated
@@ -1,8 +1,8 @@ | |||
# Installation notes for macOS Catalina (v10.15) | |||
# Installation notes for macOS Catalina (v10.15) Updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think "Updates" is needed here, it's not just about updates, it's about upgrades as well, so if we remove this word it still applies to both cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done. Happy to make changes given any guidance about wording, etc.
PR-URL: #2078 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Thanks @rvagg! |
PR-URL: #2078 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #2078 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Checklist
Description of change
Every time I do a Software Update in macOS Catalina, the command-line tools are borked with node-gyp and I need to follow this "I did all that..." section. I have also seen this affect others.
I've added a few simple changes to the steps to guide users in case the
xcode-select --install
step fails.