Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promisify remove #2225

Closed
wants to merge 2 commits into from
Closed

feat: promisify remove #2225

wants to merge 2 commits into from

Conversation

imatlopez
Copy link
Contributor

@imatlopez imatlopez commented Sep 19, 2020 •
edited
Loading

Checklist
  • npm install && npm test passes
  • tests are included
  • commit message follows commit guidelines
Description of change

An effort to modernize the code

cclauss
cclauss reviewed Nov 2, 2020
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
cclauss
cclauss requested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts and also ensure that we are testing on Python 3.9.

Update: This was fixed in a separate Pull request.

@imatlopez imatlopez requested a review from cclauss November 3, 2020 01:17
@imatlopez
Copy link
Contributor Author

@cclauss all okay with this PR?

@imatlopez imatlopez force-pushed the promisify-remove branch 2 times, most recently from 3d3f97b to b14ec62 Compare March 31, 2021 23:41
@imatlopez imatlopez mentioned this pull request Mar 31, 2021
Closed
3 tasks
cclauss
cclauss reviewed Apr 1, 2021
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cclauss cclauss self-requested a review April 1, 2021 05:37
@lukekarrys lukekarrys mentioned this pull request Dec 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blindmanyo22 blindmanyo22 blindmanyo22 approved these changes

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imatlopez @cclauss @blindmanyo22