Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 8.2.1 #2493

Closed
wants to merge 1 commit into from
Closed

chore: release 8.2.1 #2493

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 10, 2021 •
edited
Loading

🤖 I have created a release *beep* *boop*

8.2.1 (2021-10-07)

Tests

Miscellaneous

  • deps: bump make-fetch-happen from 8.0.14 to 9.1.0 (b05b4fe)
  • refactor the creation of config.gypi file (f2ad87f)

This PR was generated with Release Please. See documentation.

cclauss
cclauss approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To align with nodejs/node#40296

@cclauss cclauss requested review from gengjiawen and targos October 7, 2021 07:46
@gengjiawen gengjiawen requested a review from rvagg October 8, 2021 03:43
@rvagg
Copy link
Member

rvagg commented Oct 8, 2021

My thinking was that we should get #2497 in before a release, since f2ad87f was prep for that work. It would (presumably) be a semver-minor.

What do folks think? Try and get that in? Or push this out now and deal with that one separately?

@cclauss
Copy link
Contributor

cclauss commented Oct 11, 2021 •
edited
Loading

Would this release fix:

@gengjiawen
Copy link
Member

Would this release fix:

Looks like no. I will create another PR to bump gyp.

@gengjiawen gengjiawen mentioned this pull request Oct 11, 2021
Merged
@zcbenz
Copy link
Contributor

zcbenz commented Oct 11, 2021

I prefer making #2497 a semver-major, since it will break building modules for old versions of Electron. Rolling out the change slower can give users more time to update their Electron toolings.

@github-actions github-actions bot closed this Oct 11, 2021
@lukekarrys lukekarrys deleted the release-v8.2.1 branch March 8, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@cclauss cclauss cclauss approved these changes

@targos targos Awaiting requested review from targos

@rvagg rvagg Awaiting requested review from rvagg

Assignees
No one assigned
Labels
autorelease: pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rvagg @cclauss @gengjiawen @zcbenz