chore: skip test when python version is unsupported on platform #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2022
cclauss
requested changes
Dec 10, 2022
There was a problem hiding this comment.
Python 3.6 is not supported anywhere... https://devguide.python.org/versions
My vote would be to drop Python 3.6 and not make the changes in this PR. Allowing failure and then testing for success sounds dicey and it would be easy to have logic errors that hide important failures.
The other alternative would be to test on Ubuntu 20-04 which still supports Py36.
Another alternative would be to strategy.matrix.exclude Py36 on Ubuntu.
|
TIL about But if 3.6 is no longer supported than I agree the best idea would be to drop it from the test matrix. |
2 tasks
|
Closing in favor of #2774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
python@3.6is no longer supported onubuntu-latest(which is now22.04). See this recent workflow run to see the failure that occurs when the matrix tries to test that combination.This change makes CI skip all subsequent steps when the
setup-pythonstep fails.One downside to this is that the GitHub UI will still show ✅ for the workflow run instead of indicating that it was skipped.
Alternative options
Instead of this,
3.6could be dropped from the CI matrix, but I don't know enough about python usage to have an opinion on if that is a good idea.