Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick and dirty fix to allow WriteXmlIfChanged to write xml in utf-8, co... #366

Closed
wants to merge 2 commits into from
Closed

Quick and dirty fix to allow WriteXmlIfChanged to write xml in utf-8, co... #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b4942
Quick and dirty fix to allow WriteXmlIfChanged to write xml in utf-8,…
jfhenriques Dec 12, 2013
9f3a1b2
Update easy_xml.py
jfhenriques Dec 17, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gyp/pylib/gyp/easy_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ def WriteXmlIfChanged(content, path, encoding='utf-8', pretty=False,
xml_string = XmlToString(content, encoding, pretty)
if win32 and os.linesep != '\r\n':
xml_string = xml_string.replace('\n', '\r\n')

try:
xml_string = xml_string.encode(encoding)
except Exception:
xml_string = unicode(xml_string, 'latin-1').encode(encoding)

# Get the old content
try:
Expand Down