Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix install: add iojs support #669

Closed
wants to merge 1 commit into from
Closed

fix install: add iojs support #669

wants to merge 1 commit into from

Conversation

coderaiser
Copy link

Add iojs support: when version >=1.0.0 download dist from url https://iojs.org.

gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: 404 response downloading https://nodejs.org/dist/v2.4.0/node-v2.4.0.tar.gz
gyp ERR! stack     at Request.<anonymous> (/home/coderaiser/.nvm/versions/io.js/v2.4.0/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:251:14)
gyp ERR! stack     at emitOne (events.js:82:20)
gyp ERR! stack     at Request.emit (events.js:169:7)
gyp ERR! stack     at Request.onRequestResponse (/home/coderaiser/.nvm/versions/io.js/v2.4.0/lib/node_modules/npm/node_modules/request/request.js:985:10)
gyp ERR! stack     at emitOne (events.js:77:13)
gyp ERR! stack     at ClientRequest.emit (events.js:169:7)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient (_http_client.js:415:21)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:88:23)
gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:305:20)
gyp ERR! stack     at emitOne (events.js:77:13)

@gabeio
Copy link

gabeio commented Jul 20, 2015

👍 though also fixed in #564 ...

@thomasjo thomasjo mentioned this pull request Jul 29, 2015
20 tasks
@iamstarkov
Copy link

I think node-gyp is broken also with iojs@3.0, @gabeio @coderaiser can you take a look here paulmillr/chokidar#329?

@gabeio
Copy link

gabeio commented Aug 5, 2015

@iamstarkov I am having build issues with iojs 3 also... but sidenote you may be able to build it with 2.5.0 or lower and still use the package in 3.0.0 nevermind you can't 😢


if (!distUrl) {
if (semver.satisfies(version, '>=1.0.0')) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not reliable if NodeJS released v1.0.0 someday, I prefer process.release.node === 'io.js'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Node.js" 1.0.0 will never be released. As a TSC member, I can authoritatively say that. :)

Also, io.js is node.js now: https://github.com/nodejs/node

However, version detection still isn't a great way of doing things, though it could for for io.js 1.0.0> <3.0.0. As @camsong said, what we really should be doing now is detecting 3.0.0's process.release :)

@justinmchase
Copy link

As a workaround, you can build against electron and end up with binaries that also load into vanilla iojs:

$ npm install electron-prebuilt -g
$ npm install electron-updater-tools -g
$ elb configure 

The last command runs a script in the electron-updater-tools project that uses a --dist-url for electron that is compatible with node-gyp. It uses a delay load hack to make the binaries compatible with electron and iojs/node.

I ideally this would be fixed in node-gyp directly. Also related to this PR: #653

@rgbkrk
Copy link

rgbkrk commented Aug 24, 2015

Nice @justinmchase!

@TooTallNate
Copy link
Contributor

Superseded by #711.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants