-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gyp to b3cef02 #781
Conversation
Note this also removes support for android as gyp has abandoned it. If you still want to keep android support in the code I can just pull the two AIX changes |
@bnoordhuis can you take a look at this one |
@bnoordhuis, there were 2 PRs to update gyp if you can also look at this one it would be great. @shigeki, since you commented on the other one giving you an FYI here as well |
FYI: Currently, a floating patch of nodejs/node@58e914f is applied to tools/gyp in node so as to avoid a build error occured in MacOS without XCode. Ben has already submitted the patch to upstream in https://codereview.chromium.org/1213123002/ but it's not fixed yet. |
@iwuzhere Before I start reviewing this: node-gyp's copy of gyp was floating a few patches of its own. Did you preserve those? |
I have added the floating patches. |
I think you're missing 39a06bc. |
I shouldn't be as easy_xml.py hasnt changed in https://github.com/iWuzHere/node-gyp/commit/2f1d5efa1c747b1c0c7d5d721b25942d283606f9 and the code shows up in the repo |
LGTM but can you update the commit log with a quick overview of changes/additions? |
Includes two patches for AIX. Adds support for both 32-bit and 64-bit files[0] and uses -RPf for cp instead of -af (which is unsupported)[1] [0] https://codereview.chromium.org/1319663007 [1] https://codereview.chromium.org/1368133002
I have updated the commit message |
Includes two patches for AIX. Adds support for both 32-bit and 64-bit files[0] and uses -RPf for cp instead of -af (which is unsupported)[1] [0] https://codereview.chromium.org/1319663007 [1] https://codereview.chromium.org/1368133002 PR-URL: #781 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Thanks, landed in f5d86eb...9049241. @rvagg @TooTallNate Maybe one of you can do a release for this? |
@bnoordhuis when you say to a release is that how it gets pulled into the dependencies within Node itself ? |
Sadly, no. The chain of releases is node-gyp -> npm -> node. |
Includes two patches for AIX. Adds support for both 32-bit and 64-bit
files[0] and uses -RPf for cp instead of -af (which is unsupported)[1]
[0] https://codereview.chromium.org/1319663007
[1] https://codereview.chromium.org/1368133002
CI run here https://ci.nodejs.org/job/node-test-commit/882/
Intermittent failure that passed on rerun:
https://ci.nodejs.org/job/node-test-commit-arm/958/