Allow for npmlog@2.x #861
Closed
Allow for npmlog@2.x #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The breaking change introduced in npmlog 2.x was to anyone who was using the log as an event emitter and was listening for error events. Since node-gyp doesn't do these things, it isn't impacted by this change.
|
lgtm |
|
@ralphtheninja I believe it's so that updates are not necessarily forced and that |
rvagg
pushed a commit
that referenced
this pull request
Feb 13, 2016
The breaking change introduced in npmlog 2.x was to anyone who was using the log as an event emitter and was listening for error events. Since node-gyp doesn't do these things, it isn't impacted by this change. PR-URL: #861 Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking change introduced in npmlog 2.x was to anyone who was using the
log as an event emitter and was listening for error events. Since node-gyp
doesn't do these things, it isn't impacted by this change.