Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: fix android generator #889

Closed
wants to merge 1 commit into from

Conversation

robertchiras
Copy link
Contributor

When generating Android .mk files, ready to be used within Android build
system, we don't need LOCAL_SDK_VERSION specified, since the Android
build system already uses the latest one.
By specifying LOCAL_SDK_VERSION in Android makefiles, the build using
Android build system will fail, because the build system won't set the
path to stlport from prebuilts.

Signed-off-by: Robert Chiras robert.chiras@intel.com

Note: This patch is very useful to help integrate node into an Android build system, mostly used by vendors when generating their products. I know the android generator is not maintained anymore, but fixing this generator is crucial for building node as target in an Android build system.

When generating Android .mk files, ready to be used within Android build
system, we don't need LOCAL_SDK_VERSION specified, since the Android
build system already uses the latest one.
By specifying LOCAL_SDK_VERSION in Android makefiles, the build using
Android build system will fail, because the build system won't set the
path to stlport from prebuilts.

Signed-off-by: Robert Chiras <robert.chiras@intel.com>
bnoordhuis pushed a commit that referenced this pull request Mar 4, 2016
When generating Android .mk files, ready to be used within Android build
system, we don't need LOCAL_SDK_VERSION specified, since the Android
build system already uses the latest one.
By specifying LOCAL_SDK_VERSION in Android makefiles, the build using
Android build system will fail, because the build system won't set the
path to stlport from prebuilts.

Signed-off-by: Robert Chiras <robert.chiras@intel.com>
PR-URL: #889
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

Thanks Robert, landed in a981ef8 and released as v3.3.1.

@bnoordhuis bnoordhuis closed this Mar 4, 2016
@bnoordhuis
Copy link
Member

Also, /cc @othiym23.

@othiym23
Copy link
Contributor

othiym23 commented Mar 5, 2016

Thanks for the heads up, @bnoordhuis. node-gyp@3.3.1 will get landed in the next testing versions of npm@3 and npm@2 when they're cut next Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants