Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: de-duplicate code in downloadNodeLib() function #965

Closed
wants to merge 2 commits into from
Closed

install: de-duplicate code in downloadNodeLib() function #965

wants to merge 2 commits into from

Commits on Jun 20, 2016

  1. install: de-duplicate code in downloadNodeLib() function 

    Modified the result of processRelease() to return uniform names `libUrl`,
`libPath` for Windows in objects named as target platforms (`ia32` and `x64`)

This allows to loop over the target platforms in downloadNodeLib() and to use
the universal names instead of two almost identical code parts with `libUrl32`,
`libPath32` and `libUrl64`, `libPath64` names.
    @pmed
    pmed committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    38987b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. Merge branch 'master' into code-dedup

    @pmed
    pmed committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    e03c35f View commit details
    Browse the repository at this point in the history