This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tls: disable RC4, add --cipher-list command line switch
Disable RC4 in the default cipher list Add the `--cipher-list` command line switch and `NODE_CIPHER_LIST` environment variable to completely override the default cipher list. Add the `--enable-legacy-cipher-list` and `NODE_LEGACY_CIPHER_LIST` environment variable to selectively enable the default cipher list from previous node.js releases. Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #14413
- Loading branch information
Showing
7 changed files
with
226 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // Copyright Joyent, Inc. and other Node contributors. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a | ||
| // copy of this software and associated documentation files (the | ||
| // "Software"), to deal in the Software without restriction, including | ||
| // without limitation the rights to use, copy, modify, merge, publish, | ||
| // distribute, sublicense, and/or sell copies of the Software, and to permit | ||
| // persons to whom the Software is furnished to do so, subject to the | ||
| // following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included | ||
| // in all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
| // OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
| // MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN | ||
| // NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| // USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| var spawn = require('child_process').spawn; | ||
| var assert = require('assert'); | ||
| var tls = require('tls'); | ||
| var crypto = process.binding('crypto'); | ||
|
|
||
| function doTest(checklist, env, useswitch) { | ||
| var options; | ||
| if (env && useswitch === 1) { | ||
| options = {env:env}; | ||
| } | ||
| var args = ['-e', 'console.log(process.binding(\'crypto\').DEFAULT_CIPHER_LIST)']; | ||
|
|
||
| switch(useswitch) { | ||
| case 1: | ||
| // Test --cipher-test | ||
| args.unshift('--cipher-list=' + env); | ||
| break; | ||
| case 2: | ||
| // Test --enable-legacy-cipher-list | ||
| args.unshift('--enable-legacy-cipher-list=' + env); | ||
| break; | ||
| case 3: | ||
| // Test NODE_LEGACY_CIPHER_LIST | ||
| if (env) options = {env:{"NODE_LEGACY_CIPHER_LIST": env}}; | ||
| break; | ||
| default: | ||
| // Test NODE_CIPHER_LIST | ||
| if (env) options = {env:env}; | ||
| } | ||
|
|
||
| var out = ''; | ||
| spawn(process.execPath, args, options). | ||
| stdout. | ||
| on('data', function(data) { | ||
| out += data; | ||
| }). | ||
| on('end', function() { | ||
| assert.equal(out.trim(), checklist); | ||
| }); | ||
| } | ||
|
|
||
| doTest(crypto.DEFAULT_CIPHER_LIST); // test the default | ||
| doTest('ABC', {'NODE_CIPHER_LIST':'ABC'}); // test the envar | ||
| doTest('ABC', 'ABC', 1); // test the --cipher-list switch | ||
|
|
||
| ['v0.10.38'].forEach(function(ver) { | ||
| doTest(tls.getLegacyCiphers(ver), ver, 2); | ||
| doTest(tls.getLegacyCiphers(ver), ver, 3); | ||
| }); |
Oops, something went wrong.