req.sendHeader() should raise exception if it's already been called. #13

ry · 2009-06-28T10:32:59Z

http://groups.google.com/group/nodejs/msg/a1365b2aaa93cc7b

Call SetPointerInInternalField(0, NULL) rather than SetInternalField(0, Undefined()). Fixes the following spurious NULL pointer dereference in debug builds: #0 0x03ad2821 in v8::internal::FixedArrayBase::length () #1 0x03ad1dfc in v8::internal::FixedArray::get () #2 0x03ae05dd in v8::internal::Context::global_object () #3 0x03b6b87d in v8::internal::Context::builtins () #4 0x03ae1871 in v8::internal::Isolate::js_builtins_object () #5 0x03ab4fab in v8::CallV8HeapFunction () #6 0x03ab4d4a in v8::Value::Equals () #7 0x03b4f38b in CheckEqualsHelper () #8 0x03ac0f4b in v8::Object::SetInternalField () #9 0x06a99ddd in node::ObjectWrap::~ObjectWrap () #10 0x06a8b051 in node::Buffer::~Buffer () #11 0x06a8afbb in node::Buffer::~Buffer () #12 0x06a8af5e in node::Buffer::~Buffer () #13 0x06a9e569 in node::ObjectWrap::WeakCallback ()

Fixes the following assertion on slow systems, like our ARM buildbot: $ out/Debug/node test/simple/test-timers-unref.js node: ../src/async-wrap-inl.h:101: v8::Handle<v8::Value> node::AsyncWrap::MakeCallback(uint32_t, int, v8::Handle<v8::Value>*): Assertion `cb_v->IsFunction()' failed. Aborted The reason it only manifests on slow systems is that the test starts a 1 ms interval timer, then defers timer.unref.bind({}) to the next tick. On fast systems, the test completes in under a millisecond, before the callback is called. This commit makes timer.unref() check that the receiver actually has a timeout callback property. Fixes nodejs#13. PR-URL: nodejs/node#165 Reviewed-By: Rod Vagg <rod@vagg.org>

HenryRawas pushed a commit to HenryRawas/node that referenced this issue Jun 22, 2011

API Change: Remove unnecessary params from oio_tcp_handle_accept()

d546a31

closes nodejs#13.

HenryRawas pushed a commit to HenryRawas/node that referenced this issue Jun 22, 2011

oio_tcp_handle_accept() does not require initialization of client

c3eda7a

closes nodejs#13.

fxfred mentioned this issue Apr 11, 2012

Got error when connecting to google smtp #3073

Closed

hammer2j2 mentioned this issue Apr 17, 2012

Node.js compile fails in Amazon AMI x64 - snapshot.cc - pure functional method call #2912

Closed

Debbio mentioned this issue Jun 13, 2012

(unstable) Fatal error in ../deps/v8/src/objects-inl.h, line 2131 # CHECK(object->IsString()) failed #3427

Closed

guapigege mentioned this issue Jun 26, 2012

0.8.0 compilation fails in CentOS 6.2 #3544

Closed

barteksiudak mentioned this issue May 1, 2013

fatal error in api.h #5276

Closed

mrjoes mentioned this issue May 22, 2013

Garbage collection deadlock (0.8.22) #5443

Closed

DominicBoettger mentioned this issue Jun 3, 2013

Assertion failed: (!uv__io_active(&stream->io_watcher, UV__POLLOUT #5622

Closed

drook mentioned this issue Dec 14, 2013

node is sometimes dumping core #6702

Closed

cscott mentioned this issue Mar 14, 2014

Segfault in test-stringbytes-external.js #7309

Closed

migounette mentioned this issue May 14, 2014

node 0.11.13 - core dump - Tests (Linux) #7624

Closed

psinghsp mentioned this issue Aug 3, 2015

node.js crash in v8 parser #25801

Closed

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

req.sendHeader() should raise exception if it's already been called. #13

req.sendHeader() should raise exception if it's already been called. #13

ry commented Jun 28, 2009

req.sendHeader() should raise exception if it's already been called. #13

req.sendHeader() should raise exception if it's already been called. #13

Comments

ry commented Jun 28, 2009