This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Investigate v0.10 flaky test test-abort-fatal-error #25720
Assignees
Labels
Comments
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Jul 23, 2015
Before this change, test/simple/test-abort-fatal-error.js would fail in some environments for reasons I wasn't able to fully understand. It was marked as flaky on some systems, but not on others on which it was failing sometimes (OSX). This change back ports from v0.12 the parts of 429b5870q that apply to this test. That commit made this test adapt to changes in V8 in the v0.12 branch. After backporting these changes in v0.10, test-abort-fatal-error is not flaky anymore in environments for which it was flaky. It also has the added benefit of being more robust because it checks exit codes and signals instead of error messages. Tested on OSX and SmartOS, the only platforms on which I could reproduce the flakiness of this test. This change also removes test-abort-fatal-error from the list of flaky tests in test/simple/simple.status. Fixes nodejs#25720.
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Jul 23, 2015
Before this change, test/simple/test-abort-fatal-error.js would fail in some environments for reasons I wasn't able to fully understand. It was marked as flaky on some systems, but not on others on which it was failing sometimes (OSX). This change basically syncs test-abort-fatal-error with how it's implemented in v0.12. It back ports 429b587 (or rather the parts that apply to it since it's a merge commit), 2f5e77f and 2f5e77f. After backporting these changes in v0.10, test-abort-fatal-error is not flaky anymore in environments for which it was flaky. It also has the added benefit of being more robust because it checks exit codes and signals instead of error messages. Tested on OSX and SmartOS, the only platforms on which I could reproduce the flakiness of this test. This change also removes test-abort-fatal-error from the list of flaky tests in test/simple/simple.status. Fixes nodejs#25720.
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Jul 23, 2015
Before this change, test/simple/test-abort-fatal-error.js would fail in some environments for reasons I wasn't able to fully understand. It was marked as flaky on some systems, but not on others on which it was failing sometimes (OSX). This change basically syncs test-abort-fatal-error with how it's implemented in v0.12. It back ports 429b587 (or rather the parts that apply to it since it's a merge commit), 2f5e77f and 114bff4. After backporting these changes in v0.10, test-abort-fatal-error is not flaky anymore in environments for which it was flaky. It also has the added benefit of being more robust because it checks exit codes and signals instead of error messages. Tested on OSX and SmartOS, the only platforms on which I could reproduce the flakiness of this test. This change also removes test-abort-fatal-error from the list of flaky tests in test/simple/simple.status. Fixes nodejs#25720.
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Jul 23, 2015
Before this change, test/simple/test-abort-fatal-error.js would fail in some environments for reasons I wasn't able to fully understand. It was marked as flaky on some systems, but not on others on which it was failing sometimes (OSX). This change basically syncs test-abort-fatal-error with how it's implemented in v0.12. It back ports 429b587 (or rather the parts that apply to it since it's a merge commit), 2f5e77f and 114bff4. After backporting these changes in v0.10, test-abort-fatal-error is not flaky anymore in environments for which it was flaky. It also has the added benefit of being more robust because it checks exit codes and signals instead of error messages. Tested on OSX and SmartOS, the only platforms on which I could reproduce the flakiness of this test. This change also removes test-abort-fatal-error from the list of flaky tests in test/simple/simple.status. Fixes nodejs#25720. PR: nodejs#25755 PR-URL: nodejs#25755 Reviewed-By: João Reis <reis@janeasystems.com>
|
Fixed by e10892c. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
a2f879f marked this test as flaky in v0.10 so that it doesn't block merges with Jenkins and node-accept-pull-request.
As a follow up, we should investigate why this test is failing in v0.10. Some of the tests marked as flaky in a2f879f fail intermittently, while others fail persistently. For the latter, an explicit skip for the specific platform might be more appropriate.
My guess is that a good percentage of these tests fail because of issues with the test itself, not node. It's likely that those issues were fixed in v0.12, so it might be a good idea to look for changes to the same test in git history in v0.12, or even simply trying the v0.12 version of the test with node v0.10.
/cc: @joyent/node-collaborators
The text was updated successfully, but these errors were encountered: