Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Incorrect errno and code property values #4278

Closed
mscdex opened this issue Nov 14, 2012 · 1 comment
Closed

Incorrect errno and code property values #4278

mscdex opened this issue Nov 14, 2012 · 1 comment
Labels
windows

Comments

@mscdex
Copy link

mscdex commented Nov 14, 2012

On Windows, if I get a socket error on node 0.8.14, the error object looks like this:

{ [Error: write Unknown system errno 10058]
  code: 'Unknown system errno 10058',
  errno: 'Unknown system errno 10058',
  syscall: 'write' }
@mscdex mscdex closed this as completed Nov 14, 2012
@bnoordhuis
Copy link
Member

Back-ported joyent/libuv@483043b to v0.8 in joyent/libuv@72955c2.

richardlau pushed a commit to ibmruntimes/node that referenced this issue Dec 17, 2015
test: add test-domain-exit-dispose-again back
1effbd7 
d1ba82a "fixed"
test-domain-exit-dispose-again by changing its logic to test that
process.domain was cleared properly in case an error was thrown from
a timer's callback.

However, it became clear when reviewing a recent change that refactors
lib/timers.js that it was not quite the intention of the original test.

Thus, this change adds the original implementation of
test-domain-exit-dispose-again back, with comments that make its
implementation easier to understand.

It also preserves the changes made by
d1ba82a, but it moves them to a new
test file named test-timers-reset-process-domain-on-throw.js.

PR: nodejs#4278
PR-URL: nodejs/node#4278
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit to ibmruntimes/node that referenced this issue Feb 15, 2016
test: add test-domain-exit-dispose-again back
be39f30 
d1ba82a "fixed"
test-domain-exit-dispose-again by changing its logic to test that
process.domain was cleared properly in case an error was thrown from
a timer's callback.

However, it became clear when reviewing a recent change that refactors
lib/timers.js that it was not quite the intention of the original test.

Thus, this change adds the original implementation of
test-domain-exit-dispose-again back, with comments that make its
implementation easier to understand.

It also preserves the changes made by
d1ba82a, but it moves them to a new
test file named test-timers-reset-process-domain-on-throw.js.

PR: nodejs#4278
PR-URL: nodejs/node#4278
Reviewed-By: James M Snell <jasnell@gmail.com>
jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
@jBarz
test: add test-domain-exit-dispose-again back
e6f1f16 
d1ba82a "fixed"
test-domain-exit-dispose-again by changing its logic to test that
process.domain was cleared properly in case an error was thrown from
a timer's callback.

However, it became clear when reviewing a recent change that refactors
lib/timers.js that it was not quite the intention of the original test.

Thus, this change adds the original implementation of
test-domain-exit-dispose-again back, with comments that make its
implementation easier to understand.

It also preserves the changes made by
d1ba82a, but it moves them to a new
test file named test-timers-reset-process-domain-on-throw.js.

PR: nodejs#4278
PR-URL: nodejs/node#4278
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @bnoordhuis