Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

'make test' failing for v0.8.18 on Ubuntu 12.04 #4672

Closed
geoffreyvanwyk opened this issue Jan 28, 2013 · 4 comments
Closed

'make test' failing for v0.8.18 on Ubuntu 12.04 #4672

geoffreyvanwyk opened this issue Jan 28, 2013 · 4 comments
Labels

Comments

@geoffreyvanwyk
Copy link

This is the output of $make test

make -C out BUILDTYPE=Release V=1
make[1]: Entering directory /usr/local/src/node/out' make[1]: Nothing to be done forall'.
make[1]: Leaving directory `/usr/local/src/node/out'
ln -fs out/Release/node node
python tools/test.py --mode=release simple message
=== release test-debugger-repl ===
Path: simple/test-debugger-repl
./node debug --port=13683 /usr/local/src/node/test/fixtures/breakpoints.js
line> debug>< debugger listening on port 13683
Error: Timeout. Expected: /connecting... ok/
Command: out/Release/node /usr/local/src/node/test/simple/test-debugger-repl.js
=== release test-http-dns-fail ===
Path: simple/test-http-dns-fail
getaddrinfo ENOTFOUND
Command: out/Release/node /usr/local/src/node/test/simple/test-http-dns-fail.js
--- TIMEOUT ---
=== release test-http-curl-chunk-problem ===
Path: simple/test-http-curl-chunk-problem
dd command: dd if=/dev/zero of="/usr/local/src/node/test/tmp/big" bs=1024 count=10240
Server running at http://localhost:8080
making curl request
assert.js:102
throw new assert.AssertionError({
^
AssertionError: "8c206a1a87599f532ce68675536f0b1546900d7a" == "46dc735bdbdd00c228966cf40e6b71edbaa76ef5"
at /usr/local/src/node/test/simple/test-http-curl-chunk-problem.js:51:12
at ChildProcess.exithandler (child_process.js:538:7)
at ChildProcess.EventEmitter.emit (events.js:99:17)
at maybeClose (child_process.js:638:16)
at Process._handle.onexit (child_process.js:680:5)
Command: out/Release/node /usr/local/src/node/test/simple/test-http-curl-chunk-problem.js
=== release test-debugger-repl-utf8 ===
Path: simple/test-debugger-repl-utf8
./node debug --port=13683 /usr/local/src/node/test/fixtures/breakpoints_utf8.js
line> debug>< debugger listening on port 13683
dying badly
Error: Timeout. Expected: /connecting... ok/
Command: out/Release/node /usr/local/src/node/test/simple/test-debugger-repl-utf8.js

make: *** [test] Error 1

@bnoordhuis
Copy link
Member

The debugger tests are known bad (maybe I should say 'timing sensitive'). I have half a mind to delete them outright because it's inherent to the debugger's implementation and protocol.

The issue you're seeing with simple/test-http-curl-chunk-problem is something I have spotted very infrequently. Fixing it would be good but it's not very reproducible. What happens when you run python tools/test.py simple/test-http-curl-chunk-problem a few times?

@bnoordhuis
Copy link
Member

Forgot to mention simple/test-http-dns-fail. It assumes you have a working DNS resolver which should be true on just about every system, regardless of actual internet connectivity. The resolver is expected to return NXDOMAIN. If your upstream DNS server is slow in answering, I guess the test could time out. I'll move it to test/internet.

bnoordhuis added a commit that referenced this issue Jan 28, 2013
The test times out when the upstream DNS resolver takes too long to
respond.

See #4672.
@geoffreyvanwyk
Copy link
Author

I ran it five times. Each time it gave this output: [00:00|% 100|+ 1|- 0]: Done

@bnoordhuis
Copy link
Member

Yeah, that's what I expected. I suspect there is a race condition in the test somewhere but I haven't been able to pinpoint it. I'll look into it next time it happens. Thanks for the bug report!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants