This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Domain error handler not preventing exception from bubbling up when --abort-on-uncaught-exception used #8631
Comments
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Nov 3, 2014
Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes nodejs#8631. Also fixes nodejs#8630.
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Nov 3, 2014
Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes nodejs#8631. Also fixes nodejs#8630.
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Nov 3, 2014
Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes nodejs#8631. Also fixes nodejs#8630.
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Nov 3, 2014
Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes nodejs#8631. Also fixes nodejs#8630.
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Nov 18, 2014
Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes nodejs#8631. Also fixes nodejs#8630.
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Nov 19, 2014
Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes nodejs#8631. Also fixes nodejs#8630.
misterdjules
pushed a commit
that referenced
this issue
Nov 19, 2014
Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes: #8631 Fixes: #8630 PR-URL: #8666 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Fixed by caeb677. |
mscdex
pushed a commit
to mscdex/node
that referenced
this issue
Dec 25, 2014
Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes: nodejs#8631 Fixes: nodejs#8630 PR-URL: nodejs#8666 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When passing the
--abort-on-uncaught-exception
command line parameter to node, the top-level domain error handler does not prevent exception from bubbling up and making the process exit.The text was updated successfully, but these errors were encountered: