This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
path.parse : basename + path.sep issue #9298
Labels
Comments
I think someone misconfigured the issue mover |
Likely not ideal but the documentation here seems to be lacking so it's not clear. / cc @tjfontaine thoughts? |
There don't seem to be any test cases for trailing slash, and the test On 3 March 2015 at 23:46, James M Snell notifications@github.com wrote:
|
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this issue
Feb 22, 2017
The cherry-pick of nodejs#7612 to v4.x (4369055) added in nodejs#9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: nodejs/node#7612 Ref: nodejs/node#9298 PR-URL: nodejs/node#10732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this issue
Feb 22, 2017
The cherry-pick of nodejs#7612 to v4.x (4369055) added in nodejs#9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: nodejs/node#7612 Ref: nodejs/node#9298 PR-URL: nodejs/node#10732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi,
Don't know whether this is really an issue or not but paths with no file specified and a trailing directory path separator make the 'base' value the last directory, rather than it being blank. This seems a might inconsistent ?
I am getting the same results on Windows and Linux.
gives
as base and name are the same its a bit hard to differentiate all cases IMHO
The text was updated successfully, but these errors were encountered: