Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

src: backport fix for SIGINT crash on FreeBSD #14184

Conversation

misterdjules
Copy link

This is a backport of b64983d.

Original commit message:

src: reset signal handler to SIG_DFL on FreeBSD

FreeBSD has a nasty bug with SA_RESETHAND reseting the SA_SIGINFO,
that is in turn set for a libthr wrapper. This leads to a crash.
Work around the issue by manually setting SIG_DFL in the signal
handler.

Fix: #9326
PR-URL: nodejs/node#1218
Reviewed-By: Johan Bergström bugs@bergstroem.nu
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

Fixes #9326.

This is a backport of b64983d.

Original commit message:

  src: reset signal handler to SIG_DFL on FreeBSD

  FreeBSD has a nasty bug with SA_RESETHAND reseting the SA_SIGINFO,
  that is in turn set for a libthr wrapper. This leads to a crash.
  Work around the issue by manually setting SIG_DFL in the signal
  handler.

  Fix: nodejs#9326
  PR-URL: nodejs/node#1218
  Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Fixes nodejs#9326.
@misterdjules
Copy link
Author

Backporting since it seems FreeBSD 10.2, which is the first stable release that will ship with the fix, will not be released until November 2015.

indutny added a commit that referenced this pull request Mar 28, 2015
This is a backport of b64983d.

Original commit message:

  src: reset signal handler to SIG_DFL on FreeBSD

  FreeBSD has a nasty bug with SA_RESETHAND reseting the SA_SIGINFO,
  that is in turn set for a libthr wrapper. This leads to a crash.
  Work around the issue by manually setting SIG_DFL in the signal
  handler.

  Fix: #9326
  PR-URL: nodejs/node#1218
  Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Fixes #9326.

Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #14184
@misterdjules
Copy link
Author

Landed in 61fe1fe. @trevnorris I added you to the Reviewed-By list since you suggested to port this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants