This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
tty: no readline when TERM==dumb #25506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To stop the REPL from spitting ANSI control codes on terminals which don't support them. (Fixes #5344)
|
Any action on this? This would fix a major headache I have with the node repl. |
|
Hi, since io.js and node.js are merging at nodejs/node repository, I would recommend submitting this patch there. |
|
That said, this is one that we'd likely want to backport to v0.12... |
|
So, should I reopen this there? |
|
Yes, if you would |
|
This was reopened as nodejs/node#2712. |
silverwind
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 22, 2015
This change stops the REPL from using ANSI control codes for colours when the TERM environment variable is set to "dumb". "dumb" is the terminal type with the smallest set of capabilities as described by terminfo. See: http://invisible-island.net/ncurses/terminfo.ti.html#toc-_Specials Related: nodejs/node-v0.x-archive#5344 Related: nodejs/node-v0.x-archive#25506 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> PR-URL: #2712
rvagg
pushed a commit
to nodejs/node
that referenced
this pull request
Sep 22, 2015
This change stops the REPL from using ANSI control codes for colours when the TERM environment variable is set to "dumb". "dumb" is the terminal type with the smallest set of capabilities as described by terminfo. See: http://invisible-island.net/ncurses/terminfo.ti.html#toc-_Specials Related: nodejs/node-v0.x-archive#5344 Related: nodejs/node-v0.x-archive#25506 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> PR-URL: #2712
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stop the REPL from spitting ANSI control codes on
terminals which don't support them. (Fixes #5344)
This is a rebase and style fix of #5602.