This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
test: mark microtask-queue-run(-domain) as flaky #25606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-microtask-queue-run and test-microtask-queue-run-domain fail very rarely at least on linux x64, windows 2012r2 x64 and smartos x86
|
LGTM. Please file a P-1 issue to investigate these tests' flakiness and assign it to the next milestone v0.12.6. |
|
Issue to investigate: #25607 /cc @joyent/node-collaborators |
|
LGTM, thank you @joaocgreis 👍 |
joaocgreis
added a commit
that referenced
this pull request
Jul 2, 2015
test-microtask-queue-run and test-microtask-queue-run-domain fail very rarely at least on linux x64, windows 2012r2 x64 and smartos x86 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> PR-URL: #25606
|
Landed in 8294f32 |
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
test-microtask-queue-run and test-microtask-queue-run-domain fail very rarely at least on linux x64, windows 2012r2 x64 and smartos x86 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> PR-URL: nodejs#25606
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-microtask-queue-runandtest-microtask-queue-run-domainappear to be flaky, failing very rarely. Testing 10k runs on the platforms I have available, I got failure rates as high as:OK: 9964 NOT OK: 36OK: 9843 NOT OK: 157OK: 9904 NOT OK: 96The results appear to be influenced by the machine load, I got much lower results on an otherwise idle machine.
Quick test:
Other tests from
test-microtask-queue-*seem okay.