Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Support for Visual Studio 2015 #25857

Closed
wants to merge 4 commits into from
Closed

Support for Visual Studio 2015 #25857

wants to merge 4 commits into from

Conversation

joaocgreis
Copy link
Member

Support for Visual Studio 2015 is added in 3 steps:

  1. Update Gyp to a version that can generate VS2015 project files. 25ed9ac was chosen because it is in use by nodejs/node, thus minimizing the chances of hitting other issues. docs/, README.md and test/ were removed from the tree, and a floating patch to work on MacOSX without XCode was added in its own commit. The files under tools/gyp/ are exactly the same as the ones in nodejs/node.
  2. Add a floating patch to openssl to support VS2015. Discussion in http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390 and VS 2015 support node#478 .
  3. Add support to vcbuild.bat.

Note that to port this into v0.12, the commits discussed in #25569 are also needed and #25804 should land before.

cc @joyent/node-collaborators

@joaocgreis joaocgreis added this to the 0.10.41 milestone Aug 13, 2015
@joaocgreis joaocgreis mentioned this pull request Aug 13, 2015
Closed
@orangemocha
Copy link
Contributor

cc: @munyirik @jianchun

@jasnell jasnell added the v0.10 label Aug 16, 2015
@orangemocha
Copy link
Contributor

Test run: https://jenkins-iojs.nodesource.com/job/node-accept-pull-request/51/

@orangemocha
Copy link
Contributor

CI is happy. LGTM

joaocgreis and others added 4 commits August 24, 2015 17:20
@joaocgreis
deps: update gyp to 25ed9ac
ac64e72 
Gyp update to be able to generate VS2015 projects.
@joaocgreis
deps: fix gyp to work on MacOSX without XCode
a8c9856 
This is a port of nodejs/node@eb459c8 ,
used as a floating patch over gyp.

Original commit message:

  This issue has already submitted to the upstream in
  https://code.google.com/p/gyp/issues/detail?id=477
  Use this commit until the upstream is to be fixed.

  PR-URL: nodejs/node#1325
  Reviewed-By: Fedor Indutny <fedor@indutny.com>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@joaocgreis
deps: fix openssl for MSVS 2015
ddfd398 
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429
from openssl upstream, to add support for Visual Studio 2015. This is
already included in the newer openssl 1.0.2.

Original commit message:

  e_os.h: limit _MSC_VER trickery to older compilers.

  PR: #3390

Original pull request:

  http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390
@rvagg @joaocgreis
win: add MSVS 2015 support
408caca 
This is a port of nodejs/node@4208dc4 .

Original commit message:

  PR-URL: nodejs/node#2036
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis added a commit that referenced this pull request Aug 24, 2015
@joaocgreis
deps: update gyp to 25ed9ac
a525c72 
Gyp update to be able to generate VS2015 projects.

PR-URL: #25857
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
shigeki pushed a commit that referenced this pull request Aug 24, 2015
@joaocgreis
deps: fix gyp to work on MacOSX without XCode
9ee8a14 
This is a port of nodejs/node@eb459c8 ,
used as a floating patch over gyp.

Original commit message:

  This issue has already submitted to the upstream in
  https://code.google.com/p/gyp/issues/detail?id=477
  Use this commit until the upstream is to be fixed.

  PR-URL: nodejs/node#1325
  Reviewed-By: Fedor Indutny <fedor@indutny.com>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

PR-URL: #25857
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis pushed a commit that referenced this pull request Aug 24, 2015
@joaocgreis
deps: fix openssl for MSVS 2015
7cf0d9c 
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429
from openssl upstream, to add support for Visual Studio 2015. This is
already included in the newer openssl 1.0.2.

Original commit message:

  e_os.h: limit _MSC_VER trickery to older compilers.

  PR: #3390

Original pull request:

  http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390

PR-URL: #25857
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis pushed a commit that referenced this pull request Aug 24, 2015
@rvagg @joaocgreis
win: add MSVS 2015 support
66ec1da 
This is a port of nodejs/node@4208dc4 .

Original commit message:

  PR-URL: nodejs/node#2036
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>

PR-URL: #25857
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
@joaocgreis
Copy link
Member Author

Accept CI: https://jenkins-iojs.nodesource.com/job/node-accept-pull-request/59/

Landed in a525c72, 9ee8a14, 7cf0d9c and 66ec1da.

@joaocgreis joaocgreis closed this Aug 25, 2015
@rvagg rvagg mentioned this pull request Sep 11, 2015
Merged
joaocgreis added a commit to JaneaSystems/node that referenced this pull request Sep 12, 2015
@joaocgreis
deps: update gyp to 25ed9ac
8d0cfac 
This is a port of a525c72 .

Original commit message:

  Gyp update to be able to generate VS2015 projects.

  PR-URL: nodejs/node-v0.x-archive#25857
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis pushed a commit to JaneaSystems/node that referenced this pull request Sep 12, 2015
@joaocgreis
deps: fix gyp to work on MacOSX without XCode
b066e6a 
This is a port of eb459c8 ,
used as a floating patch over gyp.

Original commit message:

  This issue has already submitted to the upstream in
  https://code.google.com/p/gyp/issues/detail?id=477
  Use this commit until the upstream is to be fixed.

  PR-URL: nodejs#1325
  Reviewed-By: Fedor Indutny <fedor@indutny.com>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This was ported to v0.10 in nodejs/node-v0.x-archive#25857
joaocgreis pushed a commit to JaneaSystems/node that referenced this pull request Sep 12, 2015
@joaocgreis
deps: fix openssl for MSVS 2015
a7a402f 
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429
from openssl upstream, to add support for Visual Studio 2015. This is
already included in the newer openssl 1.0.2.

Original commit message:

  e_os.h: limit _MSC_VER trickery to older compilers.

  PR: nodejs#3390

Original pull request:

  http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390

This was ported to v0.10 in nodejs/node-v0.x-archive#25857
joaocgreis pushed a commit to JaneaSystems/node that referenced this pull request Sep 12, 2015
@rvagg @joaocgreis
build: add MSVS 2015 support
cd13a9e 
This is a port of 4208dc4 .

Original commit message:

  PR-URL: nodejs#2036
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>

This was ported to v0.10 in nodejs/node-v0.x-archive#25857
joaocgreis added a commit to nodejs/node that referenced this pull request Sep 16, 2015
@joaocgreis
deps: update gyp to 25ed9ac
f0fba0b 
This is a port of a525c72 .

Original commit message:

  Gyp update to be able to generate VS2015 projects.

  PR-URL: nodejs/node-v0.x-archive#25857
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>

PR-URL: #2843
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
shigeki pushed a commit to nodejs/node that referenced this pull request Sep 16, 2015
@joaocgreis
deps: fix gyp to work on MacOSX without XCode
02c262a 
This is a port of eb459c8 ,
used as a floating patch over gyp.

Original commit message:

  This issue has already submitted to the upstream in
  https://code.google.com/p/gyp/issues/detail?id=477
  Use this commit until the upstream is to be fixed.

  PR-URL: #1325
  Reviewed-By: Fedor Indutny <fedor@indutny.com>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This was ported to v0.10 in nodejs/node-v0.x-archive#25857

PR-URL: #2843
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
joaocgreis pushed a commit to nodejs/node that referenced this pull request Sep 16, 2015
@joaocgreis
deps: fix openssl for MSVS 2015
5837343 
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429
from openssl upstream, to add support for Visual Studio 2015. This is
already included in the newer openssl 1.0.2.

Original commit message:

  e_os.h: limit _MSC_VER trickery to older compilers.

  PR: #3390

Original pull request:

  http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390

This was ported to v0.10 in nodejs/node-v0.x-archive#25857

PR-URL: #2843
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
rvagg added a commit to nodejs/node that referenced this pull request Sep 16, 2015
@rvagg @joaocgreis
build: add MSVS 2015 support
08afe4e 
This is a port of 4208dc4 .

Original commit message:

  PR-URL: #2036
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>

This was ported to v0.10 in nodejs/node-v0.x-archive#25857

PR-URL: #2843
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
@ramijarrar ramijarrar mentioned this pull request Jun 23, 2016
Open
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
@joaocgreis @jBarz
deps: update gyp to 25ed9ac
2f59521 
This is a port of a525c72 .

Original commit message:

  Gyp update to be able to generate VS2015 projects.

  PR-URL: nodejs#25857
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>

PR-URL: nodejs/node#2843
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
@jBarz
deps: fix gyp to work on MacOSX without XCode
da835a6 
This is a port of eb459c8 ,
used as a floating patch over gyp.

Original commit message:

  This issue has already submitted to the upstream in
  https://code.google.com/p/gyp/issues/detail?id=477
  Use this commit until the upstream is to be fixed.

  PR-URL: nodejs/node#1325
  Reviewed-By: Fedor Indutny <fedor@indutny.com>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This was ported to v0.10 in nodejs#25857

PR-URL: nodejs/node#2843
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
@jBarz
deps: fix openssl for MSVS 2015
7a622f3 
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429
from openssl upstream, to add support for Visual Studio 2015. This is
already included in the newer openssl 1.0.2.

Original commit message:

  e_os.h: limit _MSC_VER trickery to older compilers.

  PR: nodejs#3390

Original pull request:

  http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390

This was ported to v0.10 in nodejs#25857

PR-URL: nodejs/node#2843
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
@rvagg @jBarz
build: add MSVS 2015 support
fe1e9f1 
This is a port of 4208dc4 .

Original commit message:

  PR-URL: nodejs/node#2036
  Reviewed-By: Alexis Campailla <alexis@janeasystems.com>

This was ported to v0.10 in nodejs#25857

PR-URL: nodejs/node#2843
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
build crypto gyp v0.10
Projects
None yet
Milestone
0.10.41
Development

Successfully merging this pull request may close these issues.
4 participants
@joaocgreis @orangemocha @jasnell @rvagg