This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
deps: upgrade to npm 2.14.2 #25915
Closed
deps: upgrade to npm 2.14.2 #25915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch should make the tests pass on the downstreamed npm.
|
@zkat I think that now 0.12 will be maintained in nodejs/node. |
|
@jasnell Where should I be putting this LTS PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS UPDATE INCLUDES A SECURITY FIX
Hooray, shiny new npm! See the release notes at https://github.com/npm/npm/releases/tag/v2.14.2 for details!
Aside from that, we fixed up how
preferGlobalwarnings was working because the unexpected warnings were messing with Windows PowerShell.The extra commit you see is just a patch to our test suite to make it pass when you
make test-npm-- a recent patch made it so.npmrcis never included when you pack a repo, and that broke the test suite when not testing directly in source :)r: @jasnell