This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix #3521 Use an object as the process.env proto #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Not found | ||
| return Undefined(); | ||
| // Not found. Fetch from prototype. | ||
| return info.Data()->ToObject()->Get(property); |
There was a problem hiding this comment.
You can use info.Data().As<Object>()->Get(...) here, it's a teensy bit faster.
For some reason, though, it looks like EnvGetter is not called for the key `__proto__`, so I can't make the info->Data() accessible. However, putting the Object.prototype keys there, in such a way that they are not OwnProperties, and are supersceded by environs, makes process.env much less weird.
|
Landed on master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, though, it looks like EnvGetter is not called for the
key
__proto__, so I can't make the info->Data() accessible. However,putting the Object.prototype keys there, in such a way that they are not
OwnProperties, and are supersceded by environs, makes process.env much
less weird.
Re: #3521