This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
net: initialize TCPWrap when receiving socket #4671
Closed
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| var assert = require('assert'); | ||
| var common = require('../common'); |
There was a problem hiding this comment.
common should be the first import.
TCPWrap::Initialize() and PipeWrap::Initialize() should be called before any data will be read from received socket. But, because of lazy initialization of these bindings, Initialize() method isn't called. Init bindings manually upon socket receiving. See nodejs#4669
|
Thanks, landed in 0d7a021 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCPWrap::Initialize() and PipeWrap::Initialize() should be called before
any data will be read from received socket. But, because of lazy
initialization of these bindings, Initialize() method isn't called.
Init bindings manually upon socket receiving.
See #4669
/cc @bnoordhuis