This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Create new Buffer(length) zeroed #472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't want the overhead. won't apply. |
|
I think this is a valid feature. Maybe we can expose the memset function in another way. So that you can call it from JS without necessarily running it for each Buffer allocation |
ssuda
pushed a commit
to ssuda/node
that referenced
this pull request
Mar 13, 2012
* Fix nodejs#472 Adds support for os/cpu fields in package.json (Adam Blackburn) * Don't use existing pkg if explicit * Install missing deps, even if they are in bundleDependencies * bundle node-gyp * Automatically node-gyp build stuff with a bindings.gyp * Fix nodejs#2230 Unpack in place. No folder renaming malarky * Never create un-listable directories * Fix cases where an optionalDependency fails to build * Always ignore .wafpickle-7 files * fix shrinkwrap test * Fix: bundleDependencies being re-installed unnecessarily
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a new Buffer() contains garbage:
new Buffer(5) -> Buffer 0f 82 1e 03 00, with this patch : new Buffer(5) -> Buffer 00 00 00 00 00