This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
os: add netmask to interfaces information #4883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -223,9 +223,11 @@ | |||
|
|
|||
| if (interfaces[i].address.address4.sin_family == AF_INET) { | |||
| uv_ip4_name(&interfaces[i].address.address4,ip, sizeof(ip)); | |||
| uv_ip4_name(&interfaces[i].netmask.address4,netmask, sizeof(netmask)); | |||
There was a problem hiding this comment.
Style. (I see you followed what the line above does.)
There was a problem hiding this comment.
@bnoordhuis Do you mean there should be a space after the comma? Should I fix the line above at the same time?
|
Sorry, I think this might be a duplicate of #4743. Got buried in the pull request queue. I doubt this will get looked at until after v0.10 is released. |
|
@wanderview Sorry for not checking before creating the pull request. |
|
No problem as long we get netmasks! :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch depends on joyent/libuv#730