Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

tools: add license boilerplate to check-imports.sh #6962

Closed
wants to merge 2 commits into from

Conversation

bnoordhuis
Copy link
Member

From the commit log:

I want to use this file in other projects and I don't want there to be
any misconceptions about its authorship or copyright.

The other commit makes the script a little more general purpose.

Suggested reviewer: @tjfontaine

I want to use this file in other projects and I don't want there to be
any misconceptions about its authorship or copyright.
Make it possible to invoke the script as `./check-imports.sh foo.cc`
but default to src/*.cc when invoked with no arguments for backwards
compatibility reasons.
@jasnell
Copy link
Member

jasnell commented Aug 3, 2015

@bnoordhuis ... still need/want this?

@bnoordhuis
Copy link
Member Author

I'd like to see this landed, yes, or at least the first commit.

@jasnell jasnell self-assigned this Aug 13, 2015
jasnell added a commit to jasnell/node that referenced this pull request Aug 15, 2015
@jasnell
Copy link
Member

jasnell commented Aug 15, 2015

Closing this here. New PR opened. We can cherry pick back to v0.12 if necessary. @bnoordhuis, just open a new PR if you want to apply the second commit too :-)

@jasnell jasnell closed this Aug 15, 2015
jasnell added a commit to nodejs/node that referenced this pull request Aug 23, 2015
Per: nodejs/node-v0.x-archive#6962

This applies only the first commit from nodejs/node-v0.x-archive#6962.

/cc @bnoorduis

Reviewed By: Ben Noordhuis <ben@strongloop.com>
PR-URL: #2386
jasnell added a commit to nodejs/node that referenced this pull request Aug 24, 2015
Per: nodejs/node-v0.x-archive#6962

This applies only the first commit from nodejs/node-v0.x-archive#6962.

/cc @bnoorduis

Reviewed By: Ben Noordhuis <ben@strongloop.com>
PR-URL: #2386
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants