-
Notifications
You must be signed in to change notification settings - Fork 7.3k
dgram: make .send cb act as an "error" event handler. #7738
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
// Copyright Joyent, Inc. and other Node contributors. | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a | ||
// copy of this software and associated documentation files (the | ||
// "Software"), to deal in the Software without restriction, including | ||
// without limitation the rights to use, copy, modify, merge, publish, | ||
// distribute, sublicense, and/or sell copies of the Software, and to permit | ||
// persons to whom the Software is furnished to do so, subject to the | ||
// following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included | ||
// in all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN | ||
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
// USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
||
var common = require('../common'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing license boilerplate. |
||
var assert = require('assert'); | ||
var dgram = require('dgram'); | ||
var dns = require('dns'); | ||
|
||
var socket = dgram.createSocket('udp4'); | ||
var buffer = new Buffer('gary busey'); | ||
var times = 0; | ||
|
||
dns.setServers([]); | ||
|
||
// assert that: | ||
// * callbacks act as "error" listeners if given. | ||
// * callbacks and error events are emitted in a certain order. | ||
socket.send(buffer, 0, buffer.length, 100, 'dne.example.com', callbackOnly); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the assumption that the DNS lookup will fail? It's kind of difficult to do that portably, some people are on networks where domain names always resolve to something. Grep through the logs for test/, we've repeatedly had to fix tests that made similar assumptions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm, yes -- the lookup for |
||
|
||
function callbackOnly(err) { | ||
assert.ok(err); | ||
socket.once('error', onEvent); | ||
socket.send(buffer, 0, buffer.length, 100, 'dne.example.com', onCallback); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor style issue: gratuitous blank lines.. Core tends to prefer dense code. |
||
|
||
function onEvent(err) { | ||
assert.ok(err); | ||
assert.equal(times, 0); | ||
times++; | ||
} | ||
|
||
function onCallback(err) { | ||
assert.ok(err); | ||
assert.equal(times, 1); | ||
socket.close(); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The eventOrder and callbackOrder state machine-y approach looks like it could be simplified somewhat. You're expecting one to come before the other, right? Just check in-place that order === whatever the expected value is at that time. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can drop this function and just call socket.close() from onCallback? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep! Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this redundant, can't we just rely upon the return value from
self.emit
to determine if this was handled?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we emit and there's no error listener, the error will be thrown. This check explicitly prevents that if there's a callback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right -- that part of the api -- sigh sorry