Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

timers: float delays can cause 100% cpu usage. #8067

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/timers.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ function insert(item, msecs) {
item._idleStart = Date.now();
item._monotonicStartTime = Timer.now();

// fractional delay values are not allowed; (0, 1) range
// should be coerced to 1ms.
msecs = Math.ceil(msecs);
item._idleTimeout = msecs;

if (msecs < 0) return;
Expand Down
21 changes: 21 additions & 0 deletions test/simple/test-timers-fractional-settimeout.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
var times = 0;

setInterval(function() {
process.stderr.write('.')
}, 0);

setTimeout(function() {
process.exit(times === 3 ? 0 : 1);
}, 102);

var a = setTimeout(function() {
++times;
}, 100.3);

var b = setTimeout(function() {
++times;
}, 4.3);

var c = setTimeout(function() {
++times;
}, 100);