Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

net: make Socket.connect() consistently asynchronous #8180

Closed
wants to merge 3 commits into from
Closed

net: make Socket.connect() consistently asynchronous #8180

wants to merge 3 commits into from

Commits on Nov 3, 2014

  1. net: make Socket.connect() consistently asynchronous 

    `Socket.prototype.connect()` establishes a connection
synchronously in some cases and asynchronously in others. This
commit makes it consistently asynchronous. This commit also
removes hard coded IPv4 addresses, and throws on bad inputs
immediately, instead of potentially after an asynchronous
operation.
    @cjihrig
    cjihrig committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    5dcd307 View commit details
    Browse the repository at this point in the history

  2. update based on comments on #8180

    @cjihrig
    cjihrig committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    5f88d41 View commit details
    Browse the repository at this point in the history

  3. improve port check error message and add tests

    @cjihrig
    cjihrig committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    9983e76 View commit details
    Browse the repository at this point in the history