Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

benchmark: add test for module loader #8363

Closed
wants to merge 1 commit into from

Conversation

robertkowalski
Copy link

this adds a test for benchmarking the module loader, needed for
benchmarking changes / refacortings in the module loader.

@robertkowalski
Copy link
Author

This comes handy for changes like #7094 and #7893

@trevnorris
Copy link

That's going to break on Windows. Instead make a tmp directory in the benchmark folder and delete it and all contents when the benchmark is complete. Then also add that to the .gitignore.

@robertkowalski robertkowalski force-pushed the bench-module branch 2 times, most recently from 638b2bf to d76bfa8 Compare September 18, 2014 17:48
this adds a test for benchmarking the module loader, needed for
benchmarking changes / refacortings in the module loader.
@robertkowalski
Copy link
Author

Thanks for your input @trevnorris - tmp- folder are already git-ignored and it should work on windows now.

The benchmark-runner exits after eventually output for the console is generated: https://github.com/robertkowalski/node/blob/master/benchmark/common.js#L188-L190

So there must be some tests running without output which wait for an exit code. Extending the benchmark-runner to have a teardown-method which is run before the exit to delete the files would create wrong values for those tests.

@trevnorris
Copy link

I'm cool with this. @tjfontaine feedback?

@robertkowalski ping back if no response if a few days.

@robertkowalski
Copy link
Author

ping

@tjfontaine
Copy link

lgtm

@trevnorris
Copy link

Thanks. Merged in efa47e5.

@trevnorris trevnorris closed this Sep 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants